US President Donald Trump has fired veterans affairs secretary David Shulkin in the wake of a bruising ethics scandal and a mounting rebellion within the agency.